From a278c0d852a01f345936480de0dcfa1292fb4dc7 Mon Sep 17 00:00:00 2001 From: reivilibre Date: Thu, 13 Mar 2025 14:52:00 +0000 Subject: [PATCH] Fix detection of workflow failures in the release script. (#18211) If one workflow is successful and one fails, currently that is reported as success. --------- Signed-off-by: Olivier 'reivilibre --- changelog.d/18211.misc | 1 + scripts-dev/release.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelog.d/18211.misc diff --git a/changelog.d/18211.misc b/changelog.d/18211.misc new file mode 100644 index 0000000000..9429b34f62 --- /dev/null +++ b/changelog.d/18211.misc @@ -0,0 +1 @@ +Fix detection of workflow failures in the release script. \ No newline at end of file diff --git a/scripts-dev/release.py b/scripts-dev/release.py index b14b61c705..c556ccaf86 100755 --- a/scripts-dev/release.py +++ b/scripts-dev/release.py @@ -592,7 +592,7 @@ def _wait_for_actions(gh_token: Optional[str]) -> None: if all( workflow["status"] != "in_progress" for workflow in resp["workflow_runs"] ): - success = ( + success = all( workflow["status"] == "completed" for workflow in resp["workflow_runs"] ) if success: